fix: Oracle review — portable Makefile, lint edge cases - #259
Merged
Conversation
- Makefile release target: sed → perl -pi -e (portable GNU/BSD) - Makefile: add dirty-tree guard, branch guard, install check - Makefile: fix $$CURRENT variable scope (single shell block) - lint_changelog.py: detect duplicate [Unreleased] sections - lint_changelog.py: per-version InvalidVersion handling (not all-or-nothing) Closes #258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 10 issues found in Oracle code review of the merged version-management changes.
Makefile release target
sed -i→perl -pi -e(portable across GNU/Linux and macOS/BSD)sed nin replacement →perl n(macOS was corrupting CHANGELOG)pip install -e .prerequisite check$$CURRENTvariable scope (was lost between shell lines)lint_changelog.py
[Unreleased]sections (was silently passing)InvalidVersionhandling (one bad version no longer disables all ordering checks)Other
check_public_api.py: removed stale reference to deletedscripts/check_version.pyCloses #241