Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy the necessary images from cucumber-ruby into this repository #35

Closed
olleolleolle opened this issue Sep 20, 2023 · 1 comment · Fixed by #53
Closed

Copy the necessary images from cucumber-ruby into this repository #35

olleolleolle opened this issue Sep 20, 2023 · 1 comment · Fixed by #53

Comments

@olleolleolle
Copy link
Contributor

olleolleolle commented Sep 20, 2023 •
edited
Loading

I think it would make sense to copy the image into this repository. It seems weird to borrow the assets from another project.
Cucumber Ruby is probably unaware of this dependency and may break it again in the future. Can you pick that up?

Originally posted by @mpkorstanje in #34 (comment)
@olleolleolle olleolleolle changed the title Copy the images from cucumber-ruby into this repository Copy the necessary images from cucumber-ruby into this repository Sep 20, 2023
bv added a commit to bv/cucumber-.github that referenced this issue Aug 18, 2024
@bv
Resolves cucumber#35
cb6c442 
Having own images from `cucumber-ruby` repository, references to them from the README.
bv added a commit to bv/cucumber-.github that referenced this issue Aug 18, 2024
@bv
Merge pull request #1 from bv/github.issues.35
8455b1c 
Resolves cucumber#35
@bv bv mentioned this issue Aug 18, 2024
Merged
1 task
@olleolleolle
Copy link
Contributor Author

Thanks, @bv, for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated images referenced in README bv/cucumber-.github
1 participant
@olleolleolle