Updated images referenced in README #53
Conversation
Having own images from `cucumber-ruby` repository, references to them from the README.
| @@ -2,14 +2,14 @@ | |||
| [](https://opencollective.com/cucumber) | |||
|
|
|||
| <p align="center"> | |||
| <img src="docs/img/cucumber-open-logo.png" alt="Cucumber Open - Supported by SmartBear" width="428" /> | |||
| <img src="../docs/img/cucumber-open-logo.png" alt="Cucumber Open - Supported by SmartBear" width="428" /> | |||
There was a problem hiding this comment.
One small change here is also about Smartbear vs SmartBear. I have verified and they call the company SmartBear with B, not b.
About SmartBear
| </p> | ||
|
|
||
| ## Welcome to Cucumber 👋 | ||
|
|
||
| Cucumber is a tool for running automated acceptance tests, written in plain language. Because they're written in plain language, they can be read by anyone on your team. Because they can be read by anyone, they help improve communication, collaboration and trust on your team. 💖 | ||
|
|
||
|  | ||
| <img src="../docs/img/gherkin-example.png" alt="Cucumber Gherkin Example" width="728" /> |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
thanks @olleolleolle for the review and for the suggestions.
I would like to point out and clarify couple of things which are following
in order to render right,
but it renders right now
in case if we have the absolute paths for images, each branch will be pointing to the paths like cucumber/.github/raw/main and not to the files from current branch - is it the behaviour we want?
There was a problem hiding this comment.
I apologize, my testing of "does it render right" was to watch the Diff with rich display, and then it didn't render.
There was a problem hiding this comment.
Ah, I see
well the branch in my fork looks good
https://github.com/bv/cucumber-.github/tree/github.issues.35/profile
There was a problem hiding this comment.
V good, then. I retract my suggestions!
| </p> | ||
|
|
||
| ## Welcome to Cucumber 👋 | ||
|
|
||
| Cucumber is a tool for running automated acceptance tests, written in plain language. Because they're written in plain language, they can be read by anyone on your team. Because they can be read by anyone, they help improve communication, collaboration and trust on your team. 💖 | ||
|
|
||
|  | ||
| <img src="../docs/img/gherkin-example.png" alt="Cucumber Gherkin Example" width="728" /> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -2,14 +2,14 @@ | |||
| [](https://opencollective.com/cucumber) | |||
|
|
|||
| <p align="center"> | |||
| <img src="https://github.com/cucumber/cucumber-ruby/raw/main/docs/img/cucumber-open-logo.png" alt="Cucumber Open - Supported by Smartbear" width="428" /> | |||
| <img src="../docs/img/cucumber-open-logo.png" alt="Cucumber Open - Supported by SmartBear" width="428" /> | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Alright looks good. For future reference, please follow the guide lines in: https://cbea.ms/git-commit when writing commits and issues. Currently the squashed commit suggestion looks like this:
|
mpkorstanje
changed the title
cucumber-ruby; references updated
🤔 What's changed?
New dirrectories with images have been copied over from the
cucumber-rubyrepository. The README file now references its own images.⚡️ What's your motivation?
The change resolves #35
🏷️ What kind of change is this?
📋 Checklist: