-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby] - Remove all custom ruby code (Port logic to Cucumber-Ruby) #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now ready to review and is essentially completed. The companion PR is about 85% done. |
davidjgoss
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't speak authoritatively to the Ruby code itself but the direction looks right.
Essentially the ruby code remaining is to do 1 of the 3 things (That also have some simple tests).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Amending the Ruby portion of the CCK to only contain generic items such as features and miscellaneous files.
(The miscellaneous files will be shared but not consumed yet downstream)
Items to complete
CCK::Examples
with a few minor links to determine files🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Will tag once this is good to be reviewed
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.