Message based json formatter #2888
Open
+190
−2,883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
…rmatter # Conflicts: # cucumber-bom/pom.xml # cucumber-core/src/main/java/io/cucumber/core/runner/CachingGlue.java # cucumber-core/src/test/java/io/cucumber/core/backend/StubHookDefinition.java # cucumber-core/src/test/java/io/cucumber/core/plugin/HtmlFormatterTest.java # cucumber-core/src/test/java/io/cucumber/core/plugin/JsonFormatterTest.java
…rmatter # Conflicts: # cucumber-bom/pom.xml # cucumber-core/src/test/java/io/cucumber/core/backend/StubStepDefinition.java
…rmatter # Conflicts: # cucumber-core/src/main/java/io/cucumber/core/plugin/TestSourcesModel.java
mpkorstanje
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Replace the
JsonFormatterwith the message based implementation from cucumber-json-formatter.This achieves several goals:
pluginmodule.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
The Cucumber JSON report is a de facto standard without a specification. And the existing tests did not quite cover everything. While the new implementation now has 150+ test cases, it is not impossible that something was structurally overlooked.
If you do find a problem after release please create a new issue.
📋 Checklist: