Markdown support for java #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Feature line parsing in Markdown
matchFeatureLine enhanced to support dialect, and indent, Implemented setTokenMatched
All headerLines done. Feature, Rule, Background, Examples, Scenarios and ScenarioOutline
updated the razor template updated related classes with the new Parser constructor added testcases
Update to make file to include markdowns GenerateTokens updated to pass the right TokenMatcher based on the file extension Update to MarkdownTokenMatcher and test based on local testing
Updates after some fixes in identifying the right tokens, regexs, and making sure the build passes for java
Updated documentation
mpkorstanje
reviewed
Mar 30, 2025
| @@ -183,6 +183,7 @@ export default class GherkinInMarkdownTokenMatcher implements ITokenMatcher<Toke | |||
| if (!result) { | |||
| token.matchedType = TokenType.FeatureLine | |||
| token.matchedText = token.line.trimmedLineText | |||
| token.matchedKeyword = this.dialect.feature[0] | |||
There was a problem hiding this comment.
Was this change intentional?
mpkorstanje
reviewed
Mar 30, 2025
| private final Pattern TABLE_ROW_PATTERN = Pattern.compile("^\\s{2,5}\\|.*\\S.*\\|$"); | ||
| private static final Pattern LANGUAGE_PATTERN = Pattern.compile("^\\s*#\\s*language\\s*:\\s*([a-zA-Z\\-]+)\\s*$"); | ||
| private static final String DEFAULT_DOC_STRING_SEPARATOR = "^\\s*(```[`]*)\\s*"; | ||
| private String activeDocStringSeparator = DEFAULT_DOC_STRING_SEPARATOR; |
There was a problem hiding this comment.
This doesn't look accurate.
mpkorstanje
reviewed
Mar 30, 2025
There was a problem hiding this comment.
I've not had a chance to look in detail yet but I spotted a few things that are probably wrong. You'll want to make a fairly faithful re-implementation of the type script implementation.
And also, looks like CI is not passing. You can run make clean && make acceptance locally.
Also, there have been some changes to main, it would be good to merge those into this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Adding Markdown support for Java. This will enable to define BDDs in Markdown which just simply render better.
⚡️ What's your motivation?
Address #100 .
A new feature.
I love BDD, (well love may be a strong word, but ... you get the gist), and I love seeing BDDs in Markdown.
This was already supported in javascript so seemed simple enough to replicate to Java.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
General code feedback.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.