Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ::set-output #681

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Mar 14, 2025

🤔 What's changed?

As per the deprecation warning and explanation at https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

⚡️ What's your motivation?

See cucumber/common#2150

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Is the changelog entry fine this way?

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

@nodeg nodeg self-assigned this Mar 14, 2025
@nodeg nodeg marked this pull request as ready for review March 14, 2025 20:10
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.87%. Comparing base (153db4e) to head (fa132dd).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
- Coverage   83.21%   77.87%   -5.34%     
==========================================
  Files          28       41      +13     
  Lines        3413     4050     +637     
==========================================
+ Hits         2840     3154     +314     
- Misses        458      778     +320     
- Partials      115      118       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nodeg nodeg requested a review from vearutop March 22, 2025 12:52
@vearutop vearutop merged commit 74fa488 into cucumber:main Mar 24, 2025
6 of 7 checks passed
@nodeg nodeg deleted the ci_set_output branch March 24, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants