Enhancement: Support for custom types + StepParam
type
#682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Add a new supported type to step definitions, being:
StepParam
:⚡️ What's your motivation?
We make fairly heavy use of files for test data, along with fairly heavy use of go's template engine for our inputs and file content. This, while working well, has resulted in basically every single step we define having to start with one or more of a few common function calls:
Which, while fine, is duplication that we've had to change a few times before. Combine this with not all templated input being files to be loaded, and you get a fair amount of duplicated boilerplate that eventually the
nodupl
linter complains about.Ideally, this would be automatic while also being more declarative:
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Naming, new type placement, and general opinions on the feature would be good (such as, do we even want support for customer non-struct types?).
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.