Skip to content

fix: introduce locks for delete endpoint to guarantee view counter #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cupcakearmy merged 1 commit into from
Jan 17, 2025
Merged

fix: introduce locks for delete endpoint to guarantee view counter #166

cupcakearmy merged 1 commit into from
Jan 17, 2025

Conversation

@cupcakearmy
Copy link
Owner

@cupcakearmy cupcakearmy commented Jan 17, 2025

@cupcakearmy cupcakearmy added the bug Something isn't working label Jan 17, 2025
@cupcakearmy cupcakearmy self-assigned this Jan 17, 2025
@cupcakearmy cupcakearmy merged commit 63c16a7 into main Jan 17, 2025
1 check passed
@cupcakearmy cupcakearmy deleted the fix-race-condition branch January 17, 2025 17:01
dillonstreator
dillonstreator reviewed Jan 17, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dillonstreator dillonstreator dillonstreator left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cupcakearmy cupcakearmy

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Race condition in note read - 'once read' / 'n read' not guaranteed

3 participants

@cupcakearmy @dillonstreator