refactor: simplify query combination typing #1155
Merged
+17
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My mind is drained after this session and I no longer wish to spend further time on this nor the convoluted typing 😭
The
useQueryMapping
function and correspondingcombineQueriesToObject
typing were all kinds of fucked up and broken anyway; straight up not working. I've tried to keep theuseQueryMapping
function, but trying to do so gets you into type hell.In short, instead of using
you can use
In the case of token queries it correctly deduces the type now as
Record<string, number>
, and notRecord<string, any>
, so you dont need these ugly hacks likebut can simply use
Very useful for other cases where you want to execute multiple non-batched queries and group them back into a record (like user balances, which is why I started working on this)