-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consensus simple merging #8953
base: develop
Are you sure you want to change the base?
Consensus simple merging #8953
Conversation
cvat-ui/src/components/consensus-management-page/consensus-management-page.tsx
Outdated
Show resolved
Hide resolved
supervisord/worker.consensus.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need another worker for this? Can't an existing worker, like the quality report worker, handle this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, we add a worker almost for any new activity, so this PR does the same. Probably, it can be optimized.
schema: | ||
type: string | ||
description: | | ||
The consensus merge request id. Can be specified to check operation status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be using the request API for status checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the reason is that Requests API v2 is not implemented yet. It's hard to integrate anything except import or export into the same server code. Supporting other use cases is one of the key goals of v2.
|
Motivation and context
Depends on #8939, #9026
A part of #8434
consensus
RQ queue and workerLimitations:
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.