Add RecAddDefinition and AddDefinition #106
Conversation
This commit adds support for defining functions (recursive or not) through defineFun and defineFunRec from the base API.
|
Marked as draft as the curent implementation doesn't work due to #93. |
| """Define a new SMT recursive function with the given function declaration. | ||
| Replaces constants in `args` with bound variables. | ||
|
|
||
| >>> fact = Function('fact', IntSort(), IntSort()) |
There was a problem hiding this comment.
According to Z3, a recursive function must be declared using RecFunction instead of Function. If you try to add a definition using RecAddDefinition to a function declared with Function, Z3 will trigger an error.
There was a problem hiding this comment.
I had an implementation of RecFunction but it turned out exactly the same as Function. The reason for this distinction in z3 is because they have Z3_mk_func_decl and Z3_mk_rec_func_decl, here I believe we just need mkConst to declare a function, recursive or not.
There was a problem hiding this comment.
I could add RecFunction to maintain compatibility, but do you think we should restrict the usage of RecAddDefinition like z3 does?
There was a problem hiding this comment.
We have discussed this in the cvc5 team and the conclusion is:
- we should support the same functionality that z3 does, so to have a
RecFunctionmethod - we can also have extra functionality, so it's OK to support the case where we use
Function
This commit adds support for defining functions (recursive or not) through defineFun and defineFunRec from the base API.