DevDocs Enhancement: Configurable Storage Path Implementation #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge outside project root
This commit fixes an inconsistency in how storage paths are handled between different parts of the application. Previously, the download route was using a hardcoded storage path while the main API route was using the configurable path from environment variables. The change ensures the download route uses the same storage path resolution logic, allowing files to be properly accessed when using custom storage locations. This resolves the issue where consolidated files weren't appearing in the frontend after setting a custom STORAGE_PATH.
The frontend container was trying to access a storage path that doesn't exist within the container's filesystem, causing ENOENT errors when listing files. This change: - Adds a volume mount to map host storage to the frontend container - Sets consistent STORAGE_PATH environment variable - Ensures all containers (frontend, backend, MCP) share storage access
The frontend container was attempting to access files in a directory path that existed on the host but not inside the container, resulting in "ENOENT: no such file or directory" errors when scanning the storage directory. Changes: - Add volume mount to frontend container mapping host storage to container path - Set consistent STORAGE_PATH environment variable across all containers - Fix syntax errors and improve error handling in storage/route.ts - Clean up temporary debug statements after diagnosis This ensures all containers (frontend, backend, MCP) share access to the same storage directory, allowing files created by one container to be accessible by others, which fixes file listing and retrieval in the UI.
tankcdr
changed the title
|
Hey @Shubham-Khichi is there anything you want mw to do to advance this? |
|
Hi @tankcdr sorry for delayed reply I was finding some solution to other issues, but I had your commit in mind. There seems to be conflicts on this branch with main. Can you resolve this on your side if it allows you? Else I can do it from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DevDocs Enhancement: Configurable Storage Path Implementation
Overview
This PR improves the DevDocs application by implementing a flexible storage configuration feature that allows users to separate curated data from the source code. These changes enhance the application's flexibility and usability by making the storage location fully configurable through a single environment variable, working consistently across both local development and Docker deployments.
Changes Made
Technical Implementation
Testing Done
Usage Example
Users can now set the STORAGE_PATH environment variable in their .env file:
For storage inside the project (default)
STORAGE_PATH=storage/markdownFor storage outside the project
STORAGE_PATH=/path/to/your/storageThe application will respect this path in both local and Docker deployments, allowing users to store curated data wherever is most convenient for their workflow.
Additional Notes