-
Notifications
You must be signed in to change notification settings - Fork 160
Deployment: Dockerfile and Smithery config #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
calclavia
wants to merge
3
commits into
cyberagiinc:main
Choose a base branch
from
smithery-ai:smithery/config-bya0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# Generated by https://smithery.ai. See: https://smithery.ai/docs/config#dockerfile | ||
FROM python:3.11-slim | ||
|
||
WORKDIR /app | ||
|
||
# Install system dependencies | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
build-essential \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
# Set environment variables | ||
ENV PYTHONUNBUFFERED=1 \ | ||
PYTHONDONTWRITEBYTECODE=1 | ||
|
||
# Copy MCP server code | ||
COPY fast-markdown-mcp/ /app/ | ||
|
||
# Install dependencies directly without using a virtual environment | ||
RUN pip install --no-cache-dir -e . | ||
|
||
# Create necessary directories | ||
RUN mkdir -p /app/storage/markdown | ||
|
||
# Expose the port that the MCP server might use for communication | ||
EXPOSE 8765 | ||
|
||
# Command to run the MCP server | ||
CMD ["python", "-m", "fast_markdown_mcp.server", "/app/storage/markdown"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Smithery configuration file: https://smithery.ai/docs/config#smitheryyaml | ||
|
||
startCommand: | ||
type: stdio | ||
configSchema: | ||
# JSON Schema defining the configuration options for the MCP. | ||
type: object | ||
properties: {} | ||
commandFunction: | ||
# A JS function that produces the CLI command based on the given config to start the MCP on stdio. | ||
|- | ||
(config) => ({ | ||
command: 'python', | ||
args: ['-m', 'fast_markdown_mcp.server', '/app/storage/markdown'] | ||
}) | ||
exampleConfig: {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider Consolidating RUN Commands
Currently, there are separate
RUN
instructions for installing dependencies and creating directories. Consolidating these steps (when it does not negatively affect layer caching) could help reduce the final image size by cutting down on the number of layers. Review whether merging these commands fits your build strategy.🧰 Tools
🪛 Hadolint (2.12.0)
[info] 22-22: Multiple consecutive
RUN
instructions. Consider consolidation.(DL3059)