-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
concourse-worker: add watchdog process #5
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,8 @@ | |
Description=concourse-worker | ||
Requires=network-online.target | ||
After=network-online.target | ||
Wants=concourse-worker-watchdog.service | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We will wait for concourse to fix the issue. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. currently it is a mix of both ? Sub-process is used but ext service is referenced here. Just a reminder note, for ext service this part will be missing: https://github.com/cycloidio/ansible-concourse/pull/7/files#diff-2f8071c99c715eb05ff6fabd9fed7dd5R15 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yes, I did a bunch of tests for different implementations, I must have missed some old references ^^
Good catch, I will update this PR as soon as possible to represent the ideal setup if Concourse will ever fix the issue blocking it. |
||
Before=concourse-worker-watchdog.service | ||
|
||
[Service] | ||
ExecStart={{ concourse_worker_launcher_path }} | ||
|
@@ -17,5 +19,16 @@ TasksMax=infinity | |
Delegate=yes | ||
KillMode=process | ||
|
||
## Watchdog | ||
WatchdogSec={{ concourse_worker_watchdog_sec }} | ||
NotifyAccess=main | ||
{% if concourse_worker_watchdog_terminate_on_repeating_start_failure|bool %} | ||
# If there is `StartLimitBurst` failed restart attempt | ||
# within `StartLimitInterval` then force poweroff | ||
StartLimitInterval=5min | ||
StartLimitBurst=4 | ||
StartLimitAction=poweroff-force | ||
{% endif %} | ||
|
||
[Install] | ||
WantedBy=multi-user.target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with_items could be revert ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same reason as #5 (comment)