Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add regenerate config icon #525

Merged
merged 2 commits into from
Jan 29, 2025
Merged

add regenerate config icon #525

merged 2 commits into from
Jan 29, 2025

Conversation

mabela416
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: e036ed0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cypress-design/icon-registry Minor
@cypress-design/react-icon Minor
@cypress-design/vue-icon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cypress-design ✅ Ready (Inspect) Visit Preview Jan 29, 2025 7:10pm

Copy link

cypress bot commented Jan 28, 2025

cypress-design    Run #2631

Run Properties:  status check passed Passed #2631  •  git commit 1184f5cb09 ℹ️: Merge e036ed00673b1a638eabdc04c3a97e25a802ad3c into f45f3e9bf7910b7dc60745a9e3ad...
Project cypress-design
Branch Review regenerate-config-icon
Run status status check passed Passed #2631
Run duration 02m 40s
Commit git commit 1184f5cb09 ℹ️: Merge e036ed00673b1a638eabdc04c3a97e25a802ad3c into f45f3e9bf7910b7dc60745a9e3ad...
Committer mabela416
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 230
View all changes introduced in this branch ↗︎
UI Coverage  10.87%
  Untested elements 189  
  Tested elements 25  
Accessibility  99.43%
  Failed rules  0 critical   2 serious   0 moderate   1 minor
  Failed elements 23  

@@ -0,0 +1,5 @@
---
'@cypress-design/icon-registry': patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabela416 I think you also need to have the Vue and React packages updated too if I remember from previous PRs like this. Worth verifying.

Copy link
Contributor

@ryanjwilke ryanjwilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-check the changeset on the previous icon PRs as this one feels like it's missing something.

@mabela416 mabela416 merged commit 70b6d4d into main Jan 29, 2025
13 of 15 checks passed
@mabela416 mabela416 deleted the regenerate-config-icon branch January 29, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants