Skip to content

Conversation

@tgriesser
Copy link
Member

@tgriesser tgriesser commented Nov 18, 2025

Additional details

Deals with situations where larger than expected config values are coming through to the Cloud APIs inadvertently for certain route paths.

Steps to test

Added test

How has the user experience changed?

Fixes API errors for large serialized webpack configs

PR Tasks


Note

Filters oversized user-supplied config fields before sending instance tests to Cloud, adding a sanitizing util, tests, and a changelog entry.

  • Backend (Cloud API/server):
    • postInstanceTests now sanitizes config before sending by using filterRuntimeConfigForRecoding.
    • Added filterRuntimeConfigForRecoding in packages/server/lib/config.ts to strip arbitrarily large fields (omits rawJson, collapses large env values except booleans, and replaces devServer.webpackConfig/viteConfig with omitted; mirrors handling in resolved.env).
    • Updated unit tests in packages/server/test/unit/cloud/api/api_spec.js to validate filtered payload and preserve boolean env values.
  • Changelog:
    • Notes bugfix for issues caused by unexpectedly large config values when recording to Cypress Cloud.

Written by Cursor Bugbot for commit 0a7bd3c. This will update automatically on new commits. Configure here.

@cypress
Copy link

cypress bot commented Nov 18, 2025

cypress    Run #67403

Run Properties:  status check failed Failed #67403  •  git commit 0a7bd3c37c: Merge branch 'develop' into tgriesser/fix/filter-large-user-supplied-values
Project cypress
Branch Review tgriesser/fix/filter-large-user-supplied-values
Run status status check failed Failed #67403
Run duration 19m 23s
Commit git commit 0a7bd3c37c: Merge branch 'develop' into tgriesser/fix/filter-large-user-supplied-values
Committer Tim Griesser
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 1022
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 21048
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.48%
  Untested elements 188  
  Tested elements 161  
Accessibility  97.98%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  cypress/e2e/error-handling.cy.ts • 2 failed tests • launchpad-e2e

View Output

Test Artifacts
... > automatically sources vite.config.js Test Replay Screenshots
... > automatically sources webpack.config.js Test Replay Screenshots
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > stops waiting when an xhr request is canceled
    </td>
  </tr></table>
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
src/cy/commands/files > #readFile > retries to read when ENOENT
    </td>
  </tr></table>
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Screenshots
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome:beta

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay

The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.

…values

* develop:
  chore: bump resource class for driver-integration-electron (#32959)
  chore(deps): update dependency @types/enzyme to v3.10.19 (#32961)
  chore: fix link to publish-binary job (#32949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants