-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: filter large user-supplied config values from the cloud API #32957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tgriesser
wants to merge
6
commits into
develop
Choose a base branch
from
tgriesser/fix/filter-large-user-supplied-values
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: filter large user-supplied config values from the cloud API #32957
tgriesser
wants to merge
6
commits into
develop
from
tgriesser/fix/filter-large-user-supplied-values
+86
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
tgriesser/fix/filter-large-user-supplied-values
|
| Run status |
|
| Run duration | 19m 23s |
| Commit |
|
| Committer | Tim Griesser |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
2
|
|
|
7
|
|
|
1022
|
|
|
4
|
|
|
21048
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
97.98%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
Tests for review
cypress/e2e/error-handling.cy.ts • 2 failed tests • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| ... > automatically sources vite.config.js |
Test Replay
Screenshots
|
|
| ... > automatically sources webpack.config.js |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ... > stops waiting when an xhr request is canceled |
| |||||||||||||||||||||||||
| Test | Artifacts | |||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| src/cy/commands/files > #readFile > retries to read when ENOENT |
| |||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome:beta
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Deals with situations where larger than expected config values are coming through to the Cloud APIs inadvertently for certain route paths.
Steps to test
Added test
How has the user experience changed?
Fixes API errors for large serialized webpack configs
PR Tasks
cypress-documentation?type definitions?Note
Filters oversized user-supplied config fields before sending instance tests to Cloud, adding a sanitizing util, tests, and a changelog entry.
postInstanceTestsnow sanitizesconfigbefore sending by usingfilterRuntimeConfigForRecoding.filterRuntimeConfigForRecodinginpackages/server/lib/config.tsto strip arbitrarily large fields (omitsrawJson, collapses largeenvvalues except booleans, and replacesdevServer.webpackConfig/viteConfigwithomitted; mirrors handling inresolved.env).packages/server/test/unit/cloud/api/api_spec.jsto validate filtered payload and preserve boolean env values.Written by Cursor Bugbot for commit 0a7bd3c. This will update automatically on new commits. Configure here.