Skip to content

fix: allow non standard version strings to properly parse to a semver #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: allow non standard version strings to properly parse to a semver #565

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba02710
fix: allow non standard version strings to properly parse to a semver
MTschirnich Aug 19, 2025
75ed49d
Merge branch 'main' into fix-non-standard-version-string
cyrilgdn Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion postgresql/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,8 +344,9 @@ func fingerprintCapabilities(db *sql.DB) (*semver.Version, error) {

// PostgreSQL 9.2.21 on x86_64-apple-darwin16.5.0, compiled by Apple LLVM version 8.1.0 (clang-802.0.42), 64-bit
// PostgreSQL 9.6.7, compiled by Visual C++ build 1800, 64-bit
// PostgreSQL 13.14_TDE_[...] (Ubuntu [...]) on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu [...]) [...], 64-bit
fields := strings.FieldsFunc(pgVersion, func(c rune) bool {
return unicode.IsSpace(c) || c == ','
return unicode.IsSpace(c) || c == ',' || c == '_'
})
if len(fields) < 2 {
return nil, fmt.Errorf("error determining the server version: %q", pgVersion)
Expand Down