fix: use slog instead of log to specify stdout/stderr for different l…#110
Open
qafy wants to merge 1 commit into
Open
fix: use slog instead of log to specify stdout/stderr for different l…#110qafy wants to merge 1 commit into
qafy wants to merge 1 commit into
Conversation
Owner
|
Thank you for the PR. I already added some new features and new places where logging will happen, so after merging dev, this PR will become outdated. I will definitely update this PR and merge after I merged dev into master. Leveled logging is something I wanted to implement for some time now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some problems in our setup related to #73. Our global logging instance uses the systemd journal as a source and we also host the ct server within a container and with the current server version all logging messages generate an error in our setup. I changed the logging setup to use slog instead of log as suggested in the issue and added log levels. Now only Error and warning messages get relayed to stderr everything else is written to stdout.