Expose -debug and -ldflags build options#44
Open
razor-x wants to merge 6 commits intodAppCore:mainfrom
Open
Conversation
dexter93
approved these changes
Apr 10, 2025
dexter93
left a comment
There was a problem hiding this comment.
This looks like a better version indeed. Let's do this
|
@Snider any ETA on getting this merged? 😄 i'd love to use ldflags to set the binary version dynamically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dexter93 I tired to get your PR working, but I kept getting errors due to the string passing / quoting issues.
I made a few changes and tested this version which is working. Feel free to incorporate these changes into you PR, or we can just try to get this one merged. Either is ok by me.
I am able to pass ldflags now like this which is a bit nicer UX for multiple flags.