Refactor command registration with shared helpers and metadata#92
Merged
Conversation
Contributor
🎨 Demo Preview DeployedA live preview of this PR is available at: 🔗 https://da-ba.github.io/gsp/pr-92-e1ff794/ Version: 🤖 This preview is automatically updated on each push. View all deployments at the index page. |
da-ba
marked this pull request as ready for review
February 20, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
//command list is driven by a single source of truth.Description
CommandMetadatatype, extendedregisterCommand(name, spec, metadata?)to optionally store metadata, and addedgetCommandMetadatafor lookup.src/content/commands/command-helpers.tswithgetOrLoadCommandCache(cache-or-load helper) andrunNonBlocking(ignore non-critical async errors).//command list to read metadata viagetCommandMetadatawith a fallback and removed the duplicated hardcoded metadata map./emojiand/mentionto use the new helpers and updated many command registrations (giphy,emoji,font,mermaid,mention,now,kbd,link) to includeicon+descriptionmetadata, plus docs and tests adjustments.Testing
bun run test, which succeeded (all tests passed).bun run check, which initially failed due to Prettier formatting, then fixed formatting withbunx prettier --writeand re-ranbun run check, which succeeded.src/content/commands/registry.test.tsandsrc/content/commands/command-helpers.test.tswere added/updated and executed as part of the test run.Codex Task