-
-
Notifications
You must be signed in to change notification settings - Fork 8
Laravel 12.x Compatibility #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-domain-validation.git"
}
]
}Then update your dependency constraint to reference this branch: {
"require": {
"dacoto/laravel-domain-validation": "dev-l12-compatibility",
}
}Finally, run: |
WalkthroughThe pull request updates two aspects of the project. The GitHub Actions workflow now tests an expanded range of Laravel versions—adding '12.*' to the matrix—and excludes the PHP 8.1 combination for Laravel 12. In addition, the dependency version constraint for the Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GA as GitHub Actions Runner
participant Matrix as Test Matrix
participant Suite as Test Suite
Dev->>GA: Push commit
GA->>Matrix: Load Laravel versions (10.*, 11.*, 12.*)
Matrix-->>GA: Return version combinations
alt Combination is PHP 8.1 with Laravel 12.*
GA-->>Dev: Skip test for incompatible combo
else All other combinations
GA->>Suite: Execute tests
Suite-->>GA: Return test results
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (4)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 12.x.
Before merging, you need to:
l12-compatibilitybranchIf you do find an issue, please report it by commenting on this PR to help improve future automation.
Summary by CodeRabbit
Tests
Chores