BYD Atto3: Add 10 temperature sensors to datalayer #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalathegreat
changed the title
No-Signal
reviewed
Feb 5, 2025
| battery_calc_max_temperature = battery_daughterboard_temperatures[1]; | ||
| } | ||
| for (int i = 1; i < 10; i++) { | ||
| if (i == (SKIP_TEMPERATURE_SENSOR_NUMBER - 1)) { |
There was a problem hiding this comment.
Is it a likely scenario to have multiple failed sensors? if it is should this be an array or a bitmask of allowed sensors?
There was a problem hiding this comment.
For now it is so rare that a sensor would be broken. Best to keep it safe, and only allow bypassing a single faulted sensor. We also dont know if the BMS does something when sensors fail, so let's not risk it 😓
| battery_calc_min_temperature = battery_daughterboard_temperatures[1]; | ||
| battery_calc_max_temperature = battery_daughterboard_temperatures[1]; | ||
| } | ||
| for (int i = 1; i < 10; i++) { |
There was a problem hiding this comment.
Should this start at sensor 0?
There was a problem hiding this comment.
Not needed, since we init the value to [0] element at the start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR makes it so you can track all 10 temperature sensors inside the battery
It also adds a method to skip using a specific temperature sensor, if you know it is broken.
Example, Sensor number 4 broken
Why
Better way to monitor the battery.
Also adds a way to use a battery without needing to replace a daughterboard with broken temp sensor (Note, requires deep knowledge of actual battery status)
How
All 10x measurements added to extended datalayer
Configurable option in .h file, SKIP_TEMPERATURE_SENSOR_NUMBER that can be tuned between 1-10 if needed