Fix combined search results losing keyboard focus when typing#1524
Merged
damontecres merged 2 commits intoJun 5, 2026
Conversation
damontecres
approved these changes
Jun 5, 2026
Owner
damontecres
left a comment
damontecres
left a comment
There was a problem hiding this comment.
LGTM! Thanks!
I also pushed another focus related fix. Once the user clicks search to trigger an "immediate" search, searchClicked is set to true, but doesn't ever reset. So if the user then changes the query, focus is moved down like you described in your issue. So the change just resets searchClicked to false whenever the query is changed.
Owner
|
Also, focus bugs are the worst! |
Contributor
Author
|
Thanks for the assist! Tell me about it man, its like playing whack a mole |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor tweak to prevent the keyboard from losing focus when typing search queries when "combine search results" is enabled
Related issues
Fixes #1523
Testing
Emulator only
Screenshots
N/A
AI or LLM usage
None