Fix exp 231 x86_64 CI: export resqlite_test_i64_to_str#248
Merged
Conversation
The i64 differential test symbol added in exp 231 (#247) was only declared in test/, but the FFI export scanner only scans lib/ — test-only symbols must be added to the hand-maintained _exportedSymbols list (like resqlite_test_base64_encode). macOS exports all symbols by default so the test passed locally, but the Linux version script restricts exports, so the x86_64 encoder-differential job failed with "undefined symbol". Add the symbol to the export list next to the base64 test symbol. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
danReynolds
added
the
type: correctness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #247. The x86_64
Encoder differentialCI job went red on main after #247 merged (auto-merge landed before that job finished).Cause: the i64 differential test's native symbol
resqlite_test_i64_to_strwas only declared intest/, but the FFI export scanner inhook/build.dartscanslib/only — test-only symbols must be listed in the hand-maintained_exportedSymbolsset, exactly likeresqlite_test_base64_encode. macOS exports all symbols by default (so the test passed locally on arm64), but the Linux version script restricts exports, so the symbol wasundefinedand the test threwFailed to lookup symbol.Fix: add
resqlite_test_i64_to_strto_exportedSymbolsnext to the base64 test symbol.Test plan
dart test test/native_encoder_diff_test.dartpasses on arm64 (unchanged)Encoder differentialCI job on this PR is the real gate for the Linux export path🤖 Generated with Claude Code