Skip to content

Fix idle conversation combat condition - inverted logic and undefined function call #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Fix idle conversation combat condition - inverted logic and undefined function call #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6856e56
Initial plan
Copilot Oct 16, 2025
1055670
Fix idle conversation combat condition logic
Copilot Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gamedata/scripts/talker_trigger_idle_conversation.script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ local function cooldown_ready()
end

local function someone_should_make_idle_conversation()
local result = cooldown_ready() and queries.is_player_in_combat()
local result = cooldown_ready() and not queries.is_in_combat(queries.get_player())
-- reset cooldown
if result then last_idle_conversation_time_ms = queries.get_game_time_ms() end
return result
Expand Down