Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update d type in fill_holes.py check #1668

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Update d type in fill_holes.py check #1668

merged 1 commit into from
Feb 3, 2025

Conversation

eseigel
Copy link
Contributor

@eseigel eseigel commented Jan 30, 2025

Changing data type check for catching grayscale and rgb while still allowing a pure black/white mask

Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.

Type of update
Bug fix

Associated issues
#1635

Additional context
N/A

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Changing data type check
@eseigel eseigel added this to the PlantCV v4.7 milestone Jan 30, 2025
@eseigel eseigel self-assigned this Jan 30, 2025
Copy link

deepsource-io bot commented Jan 30, 2025

Here's the code health analysis summary for commits 4995a6e..f7ca5d6. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren merged commit f984cb2 into main Feb 3, 2025
5 checks passed
@nfahlgren nfahlgren deleted the update_fill_holes branch February 3, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants