Update closing.py #1669
Merged
Update closing.py #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed len(np.unique(gray_img)) to >2
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
HaleySchuhl
previously approved these changes
Feb 21, 2025
nfahlgren
reviewed
Mar 13, 2025
plantcv/plantcv/closing.py
Outdated
| @@ -22,7 +22,7 @@ def closing(gray_img, kernel=None): | |||
| fatal_error("Input image must be grayscale or binary") | |||
|
|
|||
| # If image is binary use the faster method | |||
| if len(np.unique(gray_img)) == 2: | |||
| if len(np.unique(gray_img)) > 2: | |||
There was a problem hiding this comment.
@eseigel and @HaleySchuhl should this be <= 2?
HaleySchuhl
dismissed
their stale review
we edited the wrong check within this function
nfahlgren
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed len(np.unique(gray_img)) to >2
Describe your changes
Changed len(np.unique(gray_img)) to >2, allowing all black or white images to be treated as binary.
Type of update
Is this a:
New feature or feature enhancement
Associated issues
#1635
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md