Replace URI.escape - #1285
Merged
Merged
Replace URI.escape#1285
Conversation
Treat `prs_api_endpoint` method as that encodes parameters and returns a url so that Ruby 2.7 and below will behave the same behavior.
Generated by 🚫 Danger |
mataku
force-pushed
the
uri-escape-is-deprecated
branch
from
January 15, 2021 05:29
798c3e8 to
95feaa3
Compare
Member
|
👍🏻 looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Ruby 3.0,
URI.escapeis obsolete. See: ruby/uri#9So i treated
prs_api_endpointmethod as that encodes parameters and returns a url so that Ruby 2.7 and below will behave the same behavior.This is how i tested.
You will see that some tests about Danger::Violation class will not pass in Ruby 3.0, but the issue was already created. #1282