Catching up with dangermccann#12
Open
zarutian wants to merge 9 commits intodangermccann:masterfrom
Open
Conversation
Get the 0xSCA update
Just keeping up with dangermccann.
Just keeping up with the github repo
Just keeping up with dangermccann.
Nowhere in the DCPU-16 v1.7 spec is this behaviour specified and all other implementations do not alter memory at where the SP points at when popping.
Catching up with dangermccann, yet again. And why has github changed their pull request UI? It was so clear before which branch was being merged into which.
Owner
|
Hi, thanks for the pull request! Can you provide some information on the two new devices you added support for? Did you want me to include those JS files by default when we load index.html? Also, I'm thinking that if we add new devices we should probably allow the user to toggle them on / off in the settings screen, the way we do for other devices. |
|
I was just trying to catch up with your repo basicly and ballsed it up. The two new devices are a Simple Volatile Memory Module (pretty much a Small Graphical Screen Tile (which multiple instances are meant to Have only tested the former and I am going to test the latter soonish. -Zarutian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not I wanted! I wanted the exact opposite. I wanted to merge commits from dangermccann:master into zarutian:master.
Why has github changed their Pull Request UI? It was so clear which branch was being merged into which other branch.