-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
c7a2b7f
commit 0951c48
Showing
1 changed file
with
17 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Intent: | ||
|
||
- [ ] Explain here what the goal is, so reviewer can read the implementation and judge whether that goal is achieved. | ||
|
||
# Validation: | ||
|
||
- [ ] Are changes covered by tests so we know existing functionality is not broken? | ||
- [ ] Is the new functionality covered by tests? | ||
- [ ] For functionality that is impractical to test | ||
- [ ] is there a demo? | ||
- [ ] does it look like you'd expect? | ||
|
||
# State of PR | ||
- [ ] Ready to merge on master | ||
- [ ] CI passes | ||
- [ ] Code is documented via rustdoc commments for readers post-landing | ||
- [ ] Changes that need explanation pre-landing (why make the change) have self-review comments |