Skip to content

Commit

Permalink
Create pull_request_template.md
Browse files Browse the repository at this point in the history
  • Loading branch information
daniel-vainsencher authored Jan 20, 2021
1 parent c7a2b7f commit 0951c48
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Intent:

- [ ] Explain here what the goal is, so reviewer can read the implementation and judge whether that goal is achieved.

# Validation:

- [ ] Are changes covered by tests so we know existing functionality is not broken?
- [ ] Is the new functionality covered by tests?
- [ ] For functionality that is impractical to test
- [ ] is there a demo?
- [ ] does it look like you'd expect?

# State of PR
- [ ] Ready to merge on master
- [ ] CI passes
- [ ] Code is documented via rustdoc commments for readers post-landing
- [ ] Changes that need explanation pre-landing (why make the change) have self-review comments

0 comments on commit 0951c48

Please sign in to comment.