fix(cortex-health): accept pre-7.40.4 reviewer dispatch summaries - #1933
Open
jbmml wants to merge 1 commit into
Open
fix(cortex-health): accept pre-7.40.4 reviewer dispatch summaries#1933jbmml wants to merge 1 commit into
jbmml wants to merge 1 commit into
Conversation
validDispatchSummary required skipped_guard/skips on every success row, but those keys were added in 7.40.4. The health check reads only the latest reviewer-runs.jsonl line, which right after an upgrade is a pre-7.40.4 success lacking both keys — so a run that succeeded is reported CRITICAL until the next review fires. Treat a missing skip pair as zero guard refusals (both-or-neither; one without the other still rejects). Fail-closed cases unchanged. Adds a smoke test and updates the ObservabilitySystem doc. Fixes danielmiessler#1930.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1930.
validDispatchSummaryrequiredskipped_guard/skipson every success row, but those keys were added in 7.40.4. The health check reads only the latestreviewer-runs.jsonlline — right after an upgrade that's a pre-7.40.4 success lacking both keys — so a run that succeeded is reported CRITICAL until the next review fires.Treats a missing skip pair as zero guard refusals (both-or-neither; one field without the other still rejects). All existing fail-closed cases unchanged. Adds a self-contained smoke test (
bun …/CortexHealth.ts→ 6/0) and updates the ObservabilitySystem doc line. No writer change, no log rewrite.