feat: zero error forwarding #141
Open
+92
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Solid change. If you can add a test which asserts the error state we're good to merge IMO. Something along the lines of the test in the solid diff would be great.
|
What do you think about how this presents the error object? export interface QueryError {
refetch: () => void
details: QueryErrorDetails
}We now do not have a flat object like the solid implementation |
danielroe
reviewed
Oct 29, 2025
| return toValue(options)?.ttl ?? DEFAULT_TTL_MS | ||
| }) | ||
| const view = shallowRef<VueView<HumanReadable<TReturn>> | null>(null) | ||
| const refetchKey = ref(0) |
There was a problem hiding this comment.
I think we could use shallowRef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
zero-solid, the query statuserrorwas added which forwarded the zero error to where the query is used.I've tried to implement it here to reflect how other composables provide error values (specifically Nuxt's
useFetch)I decided to provide the
refetchfunction only within the error just likezero-solidbecause in zero the concept of manually refetching should not really be a thing.With this I changed some of the internals of the
Viewclass to reflect howuseQueryprovides the data.