Include the system notification content height in verticalOffset

[briancordanyoung]

When dynamic type becomes excessively large, the system notification view may expand and become visible while in the dismissed state. The verticalOffset of 250 is not enough to keep the view off screen.

This PR includes the height of the system notification view content in the offset ensuring that the view is not visible in these cases.

It's not clear to me, but this might allow for the base offset of 250 to be reduced.

[danielsaidi]

Hi @briancordanyoung

Thank you - looks promising! I will give it a try, and as you say, hopefully it will let us reduce or remove the base offset.

[briancordanyoung]

@danielsaidi I see this PR was rejected. Is there anything I could do to improve it? Do you have another technique you intend to use to prevent large text sizes from making the "offscreen" view visible?

[danielsaidi]

Hi @briancordanyoung

Sorry about this, I must have closed it accidentally. I've been working on most of my open-source projects in parallel to get them ready for Swift 6, and have been spreading myself a bit thin. I managed to close another issue as well 🙈

Thank you for letting me know! I'll reopen it and will take a look at it once I'm done with the Swift 6 transition.

[danielsaidi]

@briancordanyoung I think was auto-closed as a result of me renaming the master branch to main yesterday. 🫠

[danielsaidi]

Hi @briancordanyoung

I'm going through all my open-source projects and look at PRs that have gone unmerged for a while.

Do you still use/need this in the library?

[briancordanyoung]

Hi! The library is still in use but I have left the company.

[briancordanyoung]

@tiffsaka, you may want to join in. This is the library that is used for the network offline notifications.

[danielsaidi]

Hi @briancordanyoung and @tiffsaka, any news on this or should I close?