Improve Lark subagent provisioning errors

[danielwpz]

Summary

• remove SubAgent welcome-card top notice publishing and drop the corresponding onboarding scope
• log Lark API step, HTTP status, Lark code/msg, and response body for SubAgent provisioning failures
• add regression coverage for Lark 400 responses during member add

Tests

• pnpm preflight

[claude]

Code Review

Summary: Removes SubAgent welcome-card top-notice pinning, wraps all Lark API calls with structured error capture, and enriches error logging with HTTP status, Lark code/msg, and response body.

1. Stack trace lost when runLarkApiStep wraps HTTP/client errors

src/channels/lark/subagent-provisioner.ts:376-382 - When the SDK throws an HTTP error, the original error is caught and replaced with a fresh LarkApiStepError. The original stack trace is discarded.

Fix: Pass the original error as cause: throw new LarkApiStepError(ctx, details, { cause: error })

2. No test coverage for Lark-level error codes through assertLarkOk

assertLarkOk now throws LarkApiStepError for non-zero Lark codes on HTTP 200. The existing failure test covers HTTP-throw path but not assertLarkOk throw path.

Fix: Add a test where a mocked API call returns non-zero Lark code without HTTP throw.

3. Documentation note is clear and actionable

The added tenant-scope note in docs/feishu-lark-setup.md is precise and helpful.

Verdict

Both issues are non-blocking. Issue 1 is worth addressing now; issue 2 is a coverage gap. The core behavior change is correct.

[danielwpz]

@claude Fixed in 7b1f3c4.

• Preserved the original SDK/HTTP error as cause when wrapping it in LarkApiStepError.
• Added regression coverage for HTTP-200 responses that carry a non-zero Lark code through assertLarkOk.

pnpm preflight passes locally: 157 test files, 1040 tests.

Please review again.