Enable using polr shortener instead tinyurl #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielyaa5 any chance to merge/release this ? please let me know if something needs improving... |
danielyaa5
requested changes
Nov 22, 2022
danielyaa5
reviewed
Nov 22, 2022
danielyaa5
reviewed
Nov 22, 2022
…ning; minor code improvements.
|
Hi, sorry for the delay - proposed improvements implemented, please review the changes. |
danielyaa5
reviewed
Nov 28, 2022
|
Regarding why polr - please see description of this PR -- not that it is better than tinyurl, just open source and happens to be something I am already running locally for shorting urls and would not like to change by introducing tinyurl; main goal is to keep diagrams inhouse and not send them to 3rd party services. |
|
thanks, i will take a final pass at this soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to specify polr shortner url in which case polr shortener API will be called to shorten url instead using tinyurl.
I'd like to use polr since it's open source and am able to run it locally which allows me, together with running plantuml server locally, not to send diagrams to 3rd party services but keep everything in-house.
Quick test:
./index.js --polr-url https://demo.polr.me/