Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

206 follow up checkbox default value #270

Merged

Conversation

drholera
Copy link
Contributor

Hello @danirus
Here is the new implementation according to your comment in #206

@danirus
Copy link
Owner

danirus commented Feb 6, 2021

Hi @drholera, thank you for your help! :-)

@danirus danirus merged commit f89e148 into danirus:master Feb 6, 2021
@danirus
Copy link
Owner

danirus commented Feb 6, 2021

FYI, I renamed the setting to COMMENTS_XTD_DEFAULT_FOLLOWUP. Initially I proposed a name that separated "follow" from "up". But strictly speaking, follow-up is a noun, while "follow up" is a verb. So given that here follow-up is a noun I removed the underscore. Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants