Allow use of can_delete flag directly in inline definition#309
Open
jgregory-valence wants to merge 1 commit intodaniyalzade:masterfrom
Open
Allow use of can_delete flag directly in inline definition#309jgregory-valence wants to merge 1 commit intodaniyalzade:masterfrom
jgregory-valence wants to merge 1 commit intodaniyalzade:masterfrom
Conversation
The previous README had instructions about preventing the deletion of inlined models by overriding the `has_delete_permission` method on a custom subclass of the appropriate `StackedInline` or `TabularInline` class, and then passing that subclass as the `admin_class` option of `inline_reverse`. However, that method no longer works with newer versions of Django (at least with Django 4.2 and later). This commit updates the `ReverseInlineModelAdmin` class to determine `can_delete` in the same way that Django's `InlineModelAdmin` currently does, and then passes that into the custom formset factory. In that way, consumers of this library can simply set the `can_delete` option directly on their `inline_reverse` specification without subclassing one of the built-in `InlineModelAdmin` implementations. Note that this approach was necessary because the custom formset factory in `django_reverse_admin` lives outside of the `ReverseInlineModelAdmin` class, and doesn't have access to the parent class' `can_delete` property and `has_delete_permission` method.
61dc102 to
d4df21c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous README had instructions about preventing the deletion of inlined models by overriding the
has_delete_permissionmethod on a custom subclass of the appropriateStackedInlineorTabularInlineclass, and then passing that subclass as theadmin_classoption ofinline_reverse. However, that method no longer works with newer versions of Django (at least with Django 4.2 and later).This commit updates the
ReverseInlineModelAdminclass to determinecan_deletein the same way that Django'sInlineModelAdmincurrently does, and then passes that into the custom formset factory. In that way, consumers of this library can simply set thecan_deleteoption directly on theirinline_reversespecification without subclassing one of the built-inInlineModelAdminimplementations.Note that this approach was necessary because the custom formset factory in
django_reverse_adminlives outside of theReverseInlineModelAdminclass, and doesn't have access to the parent class'can_deleteproperty andhas_delete_permissionmethod.