Fix first instance rule being used as rule description for all violations of that rule and other SARIF improvements #7640
Conversation
… for all warnings for that rule
…n says it is, fix Error details: instance.runs[0].tool.driver.rules[3].defaultConfiguration.level is not one of enum values: none,note,warning,error
…date severity mapping, add more rule description mappings
|
Thanks for you contribution. I added a remark on how to keep this in sync for future changes. Possibly not something which should addressed before/in this PR. Also something like |
|
@danmar I have simplified the approach significantly. I added genericMessage output for ErrorMessage class like you recommended and have reduced the regex to a minimum. I also removed the security violation list of errors and now I just add security tag if a CWE ID exists. |
|
Actually I just made a discovery. If I make all the descriptions for the rules blank strings, github will default to the instance specific description for each and this solves the problem. So this should greatly simplify the addition. |
…o the instance description
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
That is so much better 👍 Sounds like it will both simplify our job and make the user experience better. |
…ring so it doesnst produce trailing 0s
|
Before:
After:
