Skip to content

Fix #13997 (file filter: match relative path in project file with absolute path in file filter) #7654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danmar
Copy link
Owner

@danmar danmar commented Jul 7, 2025

No description provided.

@firewave
Copy link
Collaborator

firewave commented Jul 7, 2025

This might conflict with #7645. @glankk

And the usage of Path::getCurrentPath() in code which should be operating without any knowledge of the underlying system gives me major pause...

It also lacks unit tests.

@firewave
Copy link
Collaborator

firewave commented Jul 7, 2025

It also lacks unit tests.

Ah right. You cannot unit test it because it depends on the CWD which is an obvious red flag.

Also matchglob() will now behave differently from matchglob().

@danmar
Copy link
Owner Author

danmar commented Jul 7, 2025

And the usage of Path::getCurrentPath() in code which should be operating without any knowledge of the underlying system gives me major pause...

I will fix that.. then I can unit test also.

@danmar danmar marked this pull request as draft July 7, 2025 20:33
@danmar
Copy link
Owner Author

danmar commented Jul 7, 2025

thanks.. no further reviews is needed right now I want to cleanup this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants