Skip to content

Fix #449 (Update c++ standard to c++11) #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

Conversation

glankk
Copy link
Contributor

@glankk glankk commented Jun 30, 2025

No description provided.

@danmar
Copy link
Owner

danmar commented Jun 30, 2025

@mptre
@bavison
@diamante0018
@nelsoncj-ibm
@Tal500
@chrchr-github
@datadiode
@firewave
@JohnSiegel

Do you have objections about switching from C++03 to C++11 ?

@diamante0018
Copy link
Contributor

No, I don't have any objections

@firewave
Copy link
Collaborator

@danmar Well, that's up to you to decide. I am not aware of switching to C++11 helping with any of the major known problems, so it's an arbitrary decision.

If the ticket or the PR had some reasoning there might be something to base a discussion on.

@glankk glankk changed the title Update to c++11 (fixes #449) Fix #449 (Update c++ standard to c++11) Jun 30, 2025
@mptre
Copy link
Contributor

mptre commented Jun 30, 2025 via email

@danmar
Copy link
Owner

danmar commented Jun 30, 2025

If the ticket or the PR had some reasoning there might be something to base a discussion on.

It's just that C++11 has some nicer syntax and more robustness in general.. it is not a specific problem.

@Tal500
Copy link
Contributor

Tal500 commented Jun 30, 2025

@mptre @bavison @diamante0018 @nelsoncj-ibm @Tal500 @chrchr-github @datadiode @firewave @JohnSiegel

Do you have objections about switching from C++03 to C++11 ?

Not at all. The important issue is to still support C++03 syntax analysis of simplecpp with other source code files.

@firewave
Copy link
Collaborator

It's just that C++11 has some nicer syntax and more robustness in general.. it is not a specific problem.

The question is how many people have this integrated into a C++03 codebase but I guess that feedback will come after the change.

It would allow to fix some minor warnings from various tooling. But taking the previous paragraph in mind we should hold off on those for a few weeks.

@firewave
Copy link
Collaborator

Probably makes sense to enable the two C++11 warnings for Clang in CMakeLists.txt as well.

@datadiode
Copy link
Contributor

Thanks for asking. No objections.

@hjmjohnson
Copy link

FYI: Clang-tidy has some great code analysis tools, supporting C++11 and later. I am looking forward to this transition!

@danmar danmar merged commit 0ff0149 into danmar:master Jul 3, 2025
16 checks passed
@glankk glankk deleted the cxx11 branch July 3, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants