Fixed workingFilters scope issue (which broke filtering based on results down-selected by searching). #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingFilters was defined in the scope of 'showFilter', but used outside that scope. It mostly worked, except when searching and then selecting filters. In that case, the workingFilters was set as an implicitly defined global, and the changes weren't picked up when 'OK' is clicked. - Moved the definition of workingFilters to the HeaderFilter() scope, which contains all the functions that use it. - Renamed workingFilters in the changeWorkingFilter function to baseWorkingFilter, to make it clear that we're working with a locally passed argument instead of the higher scoped workingFilters.
|
This update must be taken as a final master version of the plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workingFilters was defined in the scope of 'showFilter', but used outside that scope. It mostly worked, except when searching and then selecting filters. In that case, the workingFilters was set as an implicitly defined global, and the changes weren't picked up when 'OK' is clicked.