Phase 0 stabilization: CXDB optional + test harness#70
Merged
mattleaverton merged 5 commits intodanshapiro:mainfrom Mar 31, 2026
Merged
Conversation
Remove the assertion that cxdb.binary_addr and cxdb.http_base_url are required. When CXDB config is absent, skip CXDB startup entirely — the engine already nil-checks all CXDB access. This lets users run graphs without CXDB configured, running, or installed. Also adds the stabilization plan document. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Six test graphs that exercise engine traversal, routing, and failure handling using only tool_command nodes (no LLM involvement): - Linear: basic A → B → C traversal - HillClimber: verify loop that retries until success on 3rd attempt - Conditional: diamond node routing on outcome - FailFast: tool node failure with status verification - NoCXDBConfig: validates CXDB-optional change (empty config accepted) - WorkspaceLifecycle: setup → work → verify with filesystem state These form the validation harness for Phase 0 stabilization work. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Key changes from team review: - Add opencode as CLI backend for non-claude/codex providers; deprecate API backend entirely (new Phase 0.8) - Kilroy should not understand worktrees — always launched INTO a worktree by the caller (simplifies Phase 2.2 from "extract to hooks" to "remove") - Add self-introspection capability to supervisor (Phase 2.5.3) — system explains its own state, decisions, and plan in human-readable terms Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
The "delete git entirely" approach pushed too much onto the caller. The hook model is the right balance: engine fires lifecycle events, git hook responds with worktree creation, per-node commits, and SHA tracking. Opt-in, not enforced — but available without the caller reinventing it. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First two tasks from the stabilization plan:
cxdb.binary_addrandcxdb.http_base_urlare required. When CXDB config is absent, skip CXDB startup entirely. The engine already nil-checks all CXDB access, so this is a 4-line change with near-zero risk.tool_commandnodes (no LLM involvement) that exercise engine traversal, routing, and failure handling:Also includes the stabilization plan document outlining Phases 0–4 for architectural improvements.
Test plan
go build ./...— clean compilego test ./internal/attractor/engine/... -run TestToolGraph— all 6 new tests passcxdbsection in YAML) succeeds🤖 Generated with Claude Code