-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calculator.test.js #2303
base: rexbrown21
Are you sure you want to change the base?
Conversation
Thank you for the submission, @rexbrown21! I'll review your code shortly, hang tight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great attempt, @rexbrown21!
I would like to request a few changes before merging your work. Please review my comments below and make the appropriate changes to your code.
After you update your code locally, follow the instructions to save your changes locally and push your changes to your fork.
When you push your changes to your fork, I'll come back for another review.
Your code style completely follows the style guide. Nice job!
There are 5 tests failing. Please revisit your code and make the failing tests pass.
❌ _check should throw a TypeError if arguments are not numbers
-actual
+expected
-
+function TypeError() { [native code] }
AssertionError: expected [Function] to throw TypeError
at Context.<anonymous> (src/calculator.test.js:14:54)
at processImmediate (node:internal/timers:464:21)
❌ _check should be called once in "add"
AssertionError: expected _check to have been called exactly once, but it was called 0 times
at Context.<anonymous> (src/calculator.test.js:24:43)
at processImmediate (node:internal/timers:464:21)
❌ _check should be called once in "subtract"
AssertionError: expected _check to have been called exactly once, but it was called 0 times
at Context.<anonymous> (src/calculator.test.js:30:43)
at processImmediate (node:internal/timers:464:21)
❌ _check should be called once in "multiply"
AssertionError: expected _check to have been called exactly once, but it was called 0 times
at Context.<anonymous> (src/calculator.test.js:36:43)
at processImmediate (node:internal/timers:464:21)
❌ _check should be called once in "divide"
AssertionError: expected _check to have been called exactly once, but it was called 0 times
at Context.<anonymous> (src/calculator.test.js:42:43)
at processImmediate (node:internal/timers:464:21)
Delete me and write your Pull Request message here!