Skip to content

docs(bindings/aws.kinesis): document new metadata for custom endpoin… #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

swatimodi-scout
Copy link

@swatimodi-scout swatimodi-scout commented Aug 5, 2025

…t support e.g. LocalStack (see components-contrib#3931)

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Added documentation for the endpoint metadata property in the AWS Kinesis binding component, which allows overriding the default AWS endpoint. This is particularly useful for testing locally with tools like LocalStack.

This aligns with the code changes made in components-contrib#3931, which introduced endpoint support in the Kinesis binding.

Issue reference

Linked to components-contrib PR: dapr/components-contrib#3931

… support e.g. LocalStack (see components-contrib#3931)

Signed-off-by: swatimodi-scout <[email protected]>
… support e.g. LocalStack (see components-contrib#3931)

Signed-off-by: swatimodi-scout <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swatimodi-scout - Appreciate the commit, however you need to target the v1.16 doc repo branch for this. thanks

@msfussell msfussell added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Aug 6, 2025
@swatimodi-scout swatimodi-scout changed the base branch from v1.15 to v1.16 August 6, 2025 07:14
@swatimodi-scout swatimodi-scout changed the base branch from v1.16 to v1.15 August 6, 2025 07:14
…indings/kinesis.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@swatimodi-scout
Copy link
Author

swatimodi-scout commented Aug 6, 2025

Linked to components-contrib PR: dapr/components-contrib#3931

@msfussell Thanks for the heads up! I’ve created a new PR targeting the v1.16 branch as suggested - [https://github.com//pull/4755].

Closing this one in favor of the updated version.

@msfussell
Copy link
Member

Closing as dup of #4752

@msfussell msfussell closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-code-pr The code PR needs to be merged before the docs are updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants