Fix mask manager handling #18574
Merged
Fix mask manager handling #18574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshannoschwalm
added
bugfix
jenshannoschwalm
force-pushed
the
fix_mask_manager
branch
from
69864c4 to
f0d3431
Compare
|
@MStraeten i think the latest force-pushed versions fixes a) the stuttering and b) the hadling of masks via the mask manager (your issue) Unfortunately there seems to be no way with current code to keep the chosen mask after collapsing the mask manager to be "editable". So that is the downside from the UI responsiveness gain we got from @ralfbrown commit. So - i think this is as far as we can get with this PR without a lot of work ... |
|
seems to be a reasonable solution, thanks for the effort |
For UI responsivness we want to avoid further processing if possible, so we do some tests and possibly return immediately. *module is either the module having focus or the mask manager (module == NULL) We can skip further processing if we have 1. a module and it's not enabled 2. the mask manager and it is not expanded
jenshannoschwalm
force-pushed
the
fix_mask_manager
branch
from
f0d3431 to
ae340da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
dt_masks_events_mouse_moved()we can avoid further processing if a module is provided and it is disabled.Fixes #18560