Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on empty places list #18587

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Mar 21, 2025

The import dialog crashes on trying to add a new place when the places list is empty.

A check for an empty list is required.

fixes #18533

@paolobenve
Copy link
Contributor

tested, it works in current master

@TurboGit TurboGit added this to the 5.2 milestone Mar 22, 2025
@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc. release notes: pending labels Mar 22, 2025
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 7bf2685 into darktable-org:master Mar 22, 2025
6 checks passed
@zisoft zisoft deleted the fix-empty-places branch March 22, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes release notes: pending scope: DAM managing files, collections, archiving, metadata, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash when adding place to library
3 participants