Cache S-matrix linear-algebra artifacts for repeated solves; add docs and tests#10
Open
darkviruzz wants to merge 3 commits intomasterfrom
Open
Cache S-matrix linear-algebra artifacts for repeated solves; add docs and tests#10darkviruzz wants to merge 3 commits intomasterfrom
darkviruzz wants to merge 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_smatrix_cache, with helper methods_invalidate_smatrix_cache()and_get_smatrix_cache()that build and return cachedphiandkp@phiinverses.GetSMatrix,SolveExterior, andSolveInteriorto accept an optionalsmatrix_cacheparameter and use cachedphi/kpphiinverses when provided._invalidate_smatrix_cache()from setup and when patterned-layer epsilon is updated (added call inGridLayer_getepsand after initial layer setup).self._get_smatrix_cache()from methods likeRT_Solve,GetAmplitudes*, andVolume_integral.docs/optimization_tasks.rstdescribing 1D inference and S-matrix caching tasks and include it indocs/index.rst.tests/test_rcwa.pycovering cache availability, cached vs uncached numerical equivalence forGetSMatrix,SolveExterior, andSolveInterior, cache reuse across repeated solves, and cache invalidation after updating patterned epsilon.Testing
pytest) including the new teststest_smatrix_cache_unavailable_before_patterned_setup,test_getsmatrix_cached_vs_uncached_identical,test_exterior_interior_cached_vs_uncached_identical, andtest_smatrix_cache_reuse_and_invalidate, and all tests completed successfully.test_rcwawere also executed and remained within tolerance.Codex Task