feat: add interactive stack demo, fix board size validation, and clean up exit signals#856
Merged
Merged
Conversation
…n up exit signals
Owner
|
@vedant-kawale-27 changes you have done are relevant and legitimate but it isnt what the issue described. In the issue I meant the interactive help page. However. Keep the PR and make a separate issue for this PR and link with it |
Contributor
Author
|
Understood. I have already detailed these findings (including the interactive help page manual gaps) in a comment on the original issue. I will keep this PR open, create a new separate issue covering these specific changes (the Stack demo, Knight's Tour validation, and exit signal clean-up), and link this PR to that new issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Overview
This PR resolves validation inconsistencies, improves code readability, and adds a missing interactive demonstration for the stack data structure in the Linear Data Structures menu.
Proposed Changes
1. 💡 Feature: Interactive Stack Demo
1to100) onto the stack.Stack (top -> bottom): | val1 | val2 |) after each operation.2. 🐛 Bug Fix: Knight's Tour Board Size Validation
safe_input_intpreviously accepted1,2, or3. The minimum value limit has been corrected from1to4.3. 🧹 Code Quality: Replace Magic Numbers for Exit Signals
-111occurrences in the menu structures (run_legacy_menuandtui_menu) with the standardized INPUT_EXIT_SIGNAL macro for consistency with the rest of the codebase.Verification Done
closes #857