[infra] Add PR title checker #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type-infra
dcharkes
changed the title
dcharkes
changed the title
dcharkes
changed the title
Collaborator
Author
|
@mosuem I think this is roughly what we want. WDYT? |
mosuem
approved these changes
Jan 2, 2025
.github/pr-title-checker-config.json
Outdated
| { | ||
| "LABEL": { | ||
| "name": "The PR title has to contain a package name like \"[ffigen]\", or \"[infra]\".", | ||
| "color": "EEEEEE" |
Member
There was a problem hiding this comment.
That's quite a strong warning color
.github/pr-title-checker-config.json
Outdated
| @@ -0,0 +1,26 @@ | |||
| { | |||
| "LABEL": { | |||
| "name": "The PR title has to contain a package name like \"[ffigen]\", or \"[infra]\".", | |||
Member
There was a problem hiding this comment.
This is the label name, and not the description, IIUC. Might want to opt for something shorter.
Collaborator
Author
There was a problem hiding this comment.
Maybe we should just leave the label away completely. There's already a red/green bot checkmark/cross.
| "failure": "Failing CI test", | ||
| "notice": "" | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Maybe also add some ignore label to override? ;)
| check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: thehanimo/[email protected] |
Member
There was a problem hiding this comment.
Use hashes for github action versions https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash
Collaborator
Author
|
Thanks @mosuem! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dogfooding dart-lang/ecosystem#332 (comment).